[WIP] Add BM1370 support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx a lot Daniel for your contribution, I will review this carefully asap. |
Georges760
requested changes
Nov 25, 2024
use a *_next() Iterator-like method of retreiving CmdDelay one by one
refactor Asic trait to get rid of Vec
Georges760
requested changes
Dec 11, 2024
|
@DanielWarloch I close all complex comments, only the easy to fix ones, for you to finish this (big) PR. Then after merging it, I will work on master to add the missing parts. |
Georges760
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work is still in progress. The first I wanned get ASICs working(a few shares accepted) and then I planned do a proper clean up.