-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to demo #450
Open
github-actions
wants to merge
3
commits into
demo
Choose a base branch
from
main
base: demo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Deploy to demo #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update cache action to v4 * use setup-terraform action
* copy fieldset pattern to use as the basis for the repeater pattern (multiple input) * add a clone/delete item control for the repeater field to duplicate or remove a set of questions * formatting * add presentational component for edit view * prevent duplicate ids for input fields. Will need to map canonical id prop for other field types * use local storage for storing repeater options on the client * add function to mutate ids for cloned elements. need to make it work for all input types. : * formatting * render update radio group components id in repeater * remove empty test language from user-facing component * update ids have an optional suffix to ensure unique ids in the repeater field * sensible default for local storage * add function to get id for pattern * update id modifier string * clean up pattern logic for dropdown * refactor to use react hook form useFieldsArray * work in progress on repeater validation and structure * ignore .idea dir * dry out add pattern dropdown functions * refactor dropdown buttons and consolidate prop types * update validation to accommodate an array of objects * turn off results summary table for now * remove debugging and console statements * remove function from repeater pattern. validation occurs on individual components * turn off localstorage on the repeater for now * unified add pattern methods to fieldset and repeaters into a single method * resolve ts issue * prevent effect hook from running until decision is made about behavior * rename var for clarity * cleanup from copy/paste * remove unneeded code * remove the move control if the question is in a repeater or fieldset * handle field copy * rename test * add better tests for repeater component * default to empty state for repeater * update spacing * convert add/delete buttons to submit so they can be caught on backend * remove useform hook in repeater component * table the submit event name and value for now * fix unfound import issue * re-add useform hook. needed for pattern validation * wip on repeater field * add todo comments to help provide guidance for handoff * refactor: update single field component for better value and error handling tckt-310 * refactor: update single field component config files tckt-310 * test: update tests for single field component config files tckt-310 * fix: repeater duplicate children id issue tckt-310 * feat: implement isFormBuilder flag tckt-310 * feat: implement parse user input and submit actions for repeater tckt-310 * storybook: update stories for repeater and edit repeater form tckt-310 * refactor: clean up old files tckt-310 * chore: add db file to gitignore tchkt-310 * feat: update phone component type to tel for better user experience tckt-310 * Fix child rendering in the repeater component * Don't emit output file on typecheck step, to avoid cluttering up the filesystem * Use childComponents in PromptComponent to get the patternId * ensure terraform is installed in apply workflow (#439) * ensure terraform is installed in apply workflow * revert testing workflow in prep for launch * chore: clean up ';' in FormContents TCKT-310 * chore: remove commented code block in repeater TCKT-310 * chore: update pnpm lock yaml TCKT-310 * feat: add removeChildPattern to repaeter config and clean up types TCKT-310 * storybook: add tests for repeater pattern TCKT-310 --------- Co-authored-by: kalasgarov <[email protected]> Co-authored-by: Khayal Alasgarov <[email protected]> Co-authored-by: Daniel Naab <[email protected]>
Terraform plan for tts-10x-forms-demo Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# cloudfoundry_app.tts-10x-forms-demo-server-doj_tts-10x-forms-demo-server-doj-app_88F24765 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-forms-demo-server-doj_tts-10x-forms-demo-server-doj-app_88F24765" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-doj:e0a15c39f31815b9f443cefe019d6b89e0c97064" -> "ghcr.io/gsa-tts/forms/server-doj:8411a6a27a0782d4e5fd50b5dda60465d1ed4c74"
id = "db85f8bc-3662-4bbc-9e35-7e4b000428db"
name = "tts-10x-forms-demo-server-doj-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy. 📝 Plan generated in Post Terraform plan to PR comment #625 |
Without the env var, the storybook browser tests kept the web socket connection open indefinitely, causing our pre-commit hooks to never exit and blocking commits unless we ran it with --no-verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated PR to sync changes from main to demo.