add target blank to links

relates #90
GSG-G8 · Apr 10, 2020 · f889ccb · f889ccb
1 parent 1674892
commit f889ccb
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/client/.eslintrc.json b/client/.eslintrc.json
@@ -1,4 +1,5 @@
 {
+    "parser": "babel-eslint",
     "extends": [
         "airbnb",
         "prettier",
@@ -45,7 +46,8 @@
                 "trailingComma": "es5",
                 "singleQuote": true
             }
-        ]
+        ],
+        "react/state-in-constructor": [0, "always"]
     },
     "plugins": [
         "react",

diff --git a/client/lessVariables.js b/client/lessVariables.js
@@ -1,14 +1,12 @@
 module.exports = {
   '@primary-color': '#E8505B',
   '@white': '#FFFFFF',
-  '@light-grey': '#F0F2F9',
-  '@grey': '#E3E1E2',
   '@btn-font-weight': '400',
   '@btn-primary-color': '@primary-color',
   '@btn-danger-bg': '@primary-color',
   '@btn-danger-border': '@primary-color',
   '@btn-border-radius-base': '5px',
   '@pagination-item-bg': '#E3E1E2',
   '@pagination-item-bg-active': '@primary-color',
-  '@pagination-item-link-bg': '@light-grey',
+  '@pagination-item-link-bg': '#F0F2F9',
 };
diff --git a/client/src/components/AdminCard/index.js b/client/src/components/AdminCard/index.js
@@ -36,7 +36,9 @@ const AdminCard = ({
       )}
       <div>
         <h3>Github link</h3>
-        <a href={githbUrl}>Click</a>
+        <a href={githbUrl} target="blank">
+          Click
+        </a>
       </div>
       {student && (
         <div>
@@ -47,7 +49,9 @@ const AdminCard = ({
       {websiteLink && (
         <div>
           <h3>Website</h3>
-          <a href={websiteLink}>View</a>
+          <a href={websiteLink} target="blank">
+            View
+          </a>
         </div>
       )}
       {studentNames && (

diff --git a/client/src/containers/AdminCohortPage/index.js b/client/src/containers/AdminCohortPage/index.js
@@ -51,10 +51,8 @@ export default () => {
   });
 
   return (
-    <div className="App">
-      <AdminContainer buttonContent="Add Cohort">
-        <ul className="cohorts">{items}</ul>
-      </AdminContainer>
-    </div>
+    <AdminContainer buttonContent="Add Cohort">
+      <ul className="cohorts">{items}</ul>
+    </AdminContainer>
   );
 };