-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Unpin NumPy in the GMT Dev Tests workflow and fix the dataarray_to_matrix doctest (#3208) #3226
Conversation
This reverts commit 8605895.
… of scalar values
The "GMT Dev Tests" workflow passed four days ago (https://github.com/GenericMappingTools/pygmt/actions/runs/9508848053/job/26210865246) but suddenly failed 12 hours ago (https://github.com/GenericMappingTools/pygmt/actions/runs/9540235948/job/26291686980). There are no changed on the GMT side, so it's likely due to a broken library installed by conda-forge. I think we can go with this PR and find out why the workflow fails on Windows later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @seisman, I think we can go with this to handle compatibility between NumPy 1.x and 2.0.
Btw, do you want to bump the NumPy version on ci_tests.yml
after this? Or we keep testing NumPy 1.26 for a few more months?
pygmt/.github/workflows/ci_tests.yaml
Line 78 in 3719474
numpy-version: '1.26' |
Tried in 3fc0156, but there are dependency issues |
I think the dependency issue has been resolved. See #3292. |
float
objects (Closes Failing doctest on pygmt.clib.conversion.dataarray_to_matrix with NumPy 2.0 #2628)