Limit number of unique blockstates shown in anomalies to 500 #2313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My performance mod, ModernFix, provides an optional feature (disabled by default) that loads block & item models dynamically rather than all at startup. This drastically reduces game launch times and memory usage, and generally has little to no performance impact in-game. However, the BoP anomaly block presents a worst case scenario for the dynamic model loader, as it requests a random model (for any block state) on the main render thread roughly once a tick.
This PR attempts to mitigate the performance issue by limiting the number of unique blockstates shown by the anomaly to 500.
If this PR is accepted, and it's possible, a backport to 1.21.1 would be appreciated.