Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of unique blockstates shown in anomalies to 500 #2313

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

embeddedt
Copy link
Contributor

@embeddedt embeddedt commented Jan 3, 2025

My performance mod, ModernFix, provides an optional feature (disabled by default) that loads block & item models dynamically rather than all at startup. This drastically reduces game launch times and memory usage, and generally has little to no performance impact in-game. However, the BoP anomaly block presents a worst case scenario for the dynamic model loader, as it requests a random model (for any block state) on the main render thread roughly once a tick.

This PR attempts to mitigate the performance issue by limiting the number of unique blockstates shown by the anomaly to 500.

If this PR is accepted, and it's possible, a backport to 1.21.1 would be appreciated.

@Forstride
Copy link
Member

Forstride commented Jan 3, 2025

I don't mind this, since the anomalies definitely need performance fixes across the board, but if it's going to be limited, I'd rather it only pull from vanilla blockstates if possible.

@Adubbz Adubbz merged commit 6045e8f into Glitchfiend:1.21.4 Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants