add timeout for version check

GlobeMC · Sep 30, 2023 · 78855be · 78855be
1 parent 1071f8e
commit 78855be
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/cmds/mcla/errdb.go b/cmds/mcla/errdb.go
@@ -7,6 +7,7 @@ import (
 	"net/http"
 	"net/url"
 	"sync"
+	"time"
 
 	"github.com/GlobeMC/mcla"
 )
@@ -41,6 +42,7 @@ type versionDataT struct {
 type ghErrDB struct {
 	Prefix string
 	cachedVersion versionDataT
+	lastCheck time.Time
 }
 
 var _ mcla.ErrorDB = (*ghErrDB)(nil)
@@ -98,6 +100,10 @@ func (db *ghErrDB)getErrorDesc(id int)(desc *mcla.ErrorDesc, err error){
 }
 
 func (db *ghErrDB)checkUpdate()(err error){
+	if !db.lastCheck.IsZero() && time.Since(db.lastCheck) <= time.Minute {
+		return nil
+	}
+
 	newVersion, err := db.fetchGhDBVersion()
 	if err != nil {
 		return
@@ -151,6 +157,8 @@ func (db *ghErrDB)checkUpdate()(err error){
 		db.cachedVersion.Patch = newVersion.Patch
 	}
 	// setStorageValue("gh.db.version", db.cachedVersion)
+
+	db.lastCheck = time.Now()
 	return
 }
 

diff --git a/cmds/mcla_wasm/errdb.go b/cmds/mcla_wasm/errdb.go
@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"net/url"
 	"sync"
+	"time"
 
 	. "github.com/GlobeMC/mcla"
 )
@@ -40,6 +41,7 @@ type versionDataT struct {
 type ghErrDB struct {
 	Prefix string
 	cachedVersion versionDataT
+	lastCheck time.Time
 }
 
 var _ ErrorDB = (*ghErrDB)(nil)
@@ -94,6 +96,10 @@ func (db *ghErrDB)getErrorDesc(id int)(desc *ErrorDesc, err error){
 }
 
 func (db *ghErrDB)checkUpdate()(err error){
+	if !db.lastCheck.IsZero() && time.Since(db.lastCheck) <= time.Minute {
+		return nil
+	}
+
 	newVersion, err := db.fetchGhDBVersion()
 	if err != nil {
 		return
@@ -146,6 +152,8 @@ func (db *ghErrDB)checkUpdate()(err error){
 		db.cachedVersion.Patch = newVersion.Patch
 	}
 	setStorageValue("gh.db.version", db.cachedVersion)
+
+	db.lastCheck = time.Now()
 	return
 }