Skip to content

Commit

Permalink
Add new enterprise reviewer. (#4700)
Browse files Browse the repository at this point in the history
  • Loading branch information
jrobbins authored Jan 15, 2025
1 parent 4f97f27 commit 0006521
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
1 change: 1 addition & 0 deletions internals/approval_defs.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
]
DEBUGGABILITY_APPROVERS = IN_NDB
TESTING_APPROVERS = [
Expand Down
19 changes: 12 additions & 7 deletions internals/reminders_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -506,8 +506,9 @@ def test_get_template_data__one_due_unassigned(self, mock_now_utc):
with test_app.app_context():
actual = self.handler.get_template_data()

expected_message = (f'6 email(s) sent or logged.\n'
expected_message = (f'7 email(s) sent or logged.\n'
'Recipients:\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
Expand Down Expand Up @@ -549,8 +550,9 @@ def test_get_template_data__initial_overdue_unassigned(self, mock_now_utc):
with test_app.app_context():
actual = self.handler.get_template_data()

expected_message = (f'6 email(s) sent or logged.\n'
expected_message = (f'7 email(s) sent or logged.\n'
'Recipients:\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
Expand All @@ -573,9 +575,10 @@ def test_get_template_data__initial_overdue_assigned(self, mock_now_utc):
with test_app.app_context():
actual = self.handler.get_template_data()

expected_message = (f'7 email(s) sent or logged.\n'
expected_message = (f'8 email(s) sent or logged.\n'
'Recipients:\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
Expand All @@ -596,8 +599,9 @@ def test_get_template_data__due_resolve_unassigned(self, mock_now_utc):
with test_app.app_context():
actual = self.handler.get_template_data()

expected_message = (f'6 email(s) sent or logged.\n'
expected_message = (f'7 email(s) sent or logged.\n'
'Recipients:\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
Expand All @@ -619,8 +623,9 @@ def test_get_template_data__resolve_overdue_unassigned(self, mock_now_utc):
with test_app.app_context():
actual = self.handler.get_template_data()

expected_message = (f'6 email(s) sent or logged.\n'
expected_message = (f'7 email(s) sent or logged.\n'
'Recipients:\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
Expand Down Expand Up @@ -684,7 +689,7 @@ def test_build_gate_email_tasks__initial_overdue(self):
{self.feature_1.key.integer_id(): self.feature_1},
True, True)

self.assertEqual(8, len(actual))
self.assertEqual(9, len(actual))
task = actual[0]
self.assertEqual('[email protected]', task['to'])
self.assertEqual('ESCALATED: Review due for: feature one', task['subject'])
Expand Down Expand Up @@ -722,7 +727,7 @@ def test_build_gate_email_tasks__resolution_overdue(self):
{self.feature_1.key.integer_id(): self.feature_1},
True, False)

self.assertEqual(8, len(actual))
self.assertEqual(9, len(actual))
task = actual[0]
self.assertEqual('[email protected]', task['to'])
self.assertEqual('ESCALATED: Review due for: feature one', task['subject'])
Expand Down

0 comments on commit 0006521

Please sign in to comment.