-
Notifications
You must be signed in to change notification settings - Fork 384
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add new enterprise reviewer. (#4700)
- Loading branch information
Showing
2 changed files
with
13 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,7 @@ | |
'[email protected]', | ||
'[email protected]', | ||
'[email protected]', | ||
'[email protected]', | ||
] | ||
DEBUGGABILITY_APPROVERS = IN_NDB | ||
TESTING_APPROVERS = [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -506,8 +506,9 @@ def test_get_template_data__one_due_unassigned(self, mock_now_utc): | |
with test_app.app_context(): | ||
actual = self.handler.get_template_data() | ||
|
||
expected_message = (f'6 email(s) sent or logged.\n' | ||
expected_message = (f'7 email(s) sent or logged.\n' | ||
'Recipients:\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
|
@@ -549,8 +550,9 @@ def test_get_template_data__initial_overdue_unassigned(self, mock_now_utc): | |
with test_app.app_context(): | ||
actual = self.handler.get_template_data() | ||
|
||
expected_message = (f'6 email(s) sent or logged.\n' | ||
expected_message = (f'7 email(s) sent or logged.\n' | ||
'Recipients:\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
|
@@ -573,9 +575,10 @@ def test_get_template_data__initial_overdue_assigned(self, mock_now_utc): | |
with test_app.app_context(): | ||
actual = self.handler.get_template_data() | ||
|
||
expected_message = (f'7 email(s) sent or logged.\n' | ||
expected_message = (f'8 email(s) sent or logged.\n' | ||
'Recipients:\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
|
@@ -596,8 +599,9 @@ def test_get_template_data__due_resolve_unassigned(self, mock_now_utc): | |
with test_app.app_context(): | ||
actual = self.handler.get_template_data() | ||
|
||
expected_message = (f'6 email(s) sent or logged.\n' | ||
expected_message = (f'7 email(s) sent or logged.\n' | ||
'Recipients:\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
|
@@ -619,8 +623,9 @@ def test_get_template_data__resolve_overdue_unassigned(self, mock_now_utc): | |
with test_app.app_context(): | ||
actual = self.handler.get_template_data() | ||
|
||
expected_message = (f'6 email(s) sent or logged.\n' | ||
expected_message = (f'7 email(s) sent or logged.\n' | ||
'Recipients:\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
'[email protected]\n' | ||
|
@@ -684,7 +689,7 @@ def test_build_gate_email_tasks__initial_overdue(self): | |
{self.feature_1.key.integer_id(): self.feature_1}, | ||
True, True) | ||
|
||
self.assertEqual(8, len(actual)) | ||
self.assertEqual(9, len(actual)) | ||
task = actual[0] | ||
self.assertEqual('[email protected]', task['to']) | ||
self.assertEqual('ESCALATED: Review due for: feature one', task['subject']) | ||
|
@@ -722,7 +727,7 @@ def test_build_gate_email_tasks__resolution_overdue(self): | |
{self.feature_1.key.integer_id(): self.feature_1}, | ||
True, False) | ||
|
||
self.assertEqual(8, len(actual)) | ||
self.assertEqual(9, len(actual)) | ||
task = actual[0] | ||
self.assertEqual('[email protected]', task['to']) | ||
self.assertEqual('ESCALATED: Review due for: feature one', task['subject']) | ||
|