Implement LFC survey question form #4744
Conversation
| window.csClient | ||
| .updateGate(this.feature.id, this.gate.id, null, {[name]: value}) | ||
| .then(() => { | ||
| this.refetch(); | ||
| }); |
There was a problem hiding this comment.
This will send a request for every time any field changes state, including for each new character change in an input field. Would a "Submit" option be a better choice to avoid the potential of redundant requests?
There was a problem hiding this comment.
Actually, the sl-change event is only sent once the user un-focuses on the input field or navigates away. So, it is not one for every keystroke. I am thinking that automatic updates are better than having a submit button because there are already enough buttons to compete for the user's attention. Specifically, after filling in these answers, the user will be often be clicking on the "Request review" button. I don't want them to have to fill-in and press submit before being able to press the "Request review" button.
There was a problem hiding this comment.
Ah, you are correct about the unfocus aspect 🙂 - although, maybe there is a risk of the user not unfocusing for something - it's like you said about the likelihood of the "Request review" button being the next action - so that sounds fine to me
This should resolve #4696. The privacy gates will offer self-certification instead of review, but only if the user enters survey question answers that cause the server to set self_certify_eligible to True. This PR just displays the form and saves any value changes to the server. A future PR will change the behavior of the "Request review" button for the eligible case.
In this PR: