fix: wait for context should respect already existing contexts #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Jan 17, 2025
|
should it be a |
sadym-chromium
changed the title
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [1.1.0](chromium-bidi-v1.0.0...chromium-bidi-v1.1.0) (2025-01-17) ### Features * support `goog:channel` along with `channel` ([#2996](#2996)) ([d7ed911](d7ed911)) ### Bug Fixes * multi headers reporting incorrectly ([#2987](#2987)) ([0e58eb7](0e58eb7)) * wait for context should respect already existing contexts ([#2998](#2998)) ([f6cb8ec](f6cb8ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address Puppeteer test failures: https://github.com/GoogleChromeLabs/chromium-bidi/actions/runs/12827546451/job/35769733285?pr=2993
Tested manually. 1000 times run Puppeteer test "[locator.spec] Locator Locator.prototype.filter should resolve as soon as the predicate matches" with and without the change. Problem is gone.