Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review output messages on the PSAT CLI #807

Open
fellyph opened this issue Aug 14, 2024 · 0 comments
Open

Review output messages on the PSAT CLI #807

fellyph opened this issue Aug 14, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@fellyph
Copy link
Collaborator

fellyph commented Aug 14, 2024

Describe the bug
Testing the verbose mode, I have found some typos in the output messages:

Analyzing cookies on first site visit
    Browser intialized
    Page opened
    Attaching network event listeners to page
    Finished attaching network event listeners
    Starting navigation to URL: https://globo.com
    Navigation did not finish in 10 seconds moving on to scrolling
    Scrolling on URL: https://globo.com

Suggested text:

Analyzing cookies on the first site visit
    Browser initialized
    Page opened
    Attaching network event listeners to the page
    Finished attaching network event listeners
    Starting navigation to URL: https://globo.com
    Navigation did not finish in 10 seconds moving on to scrolling
    Scrolling on URL: https://globo.com

The step Navigation did not finish in 10 seconds moving on to scrolling also needs some rephrasing to describe better the action taken on this step.

This issue also includes the review of other internal messages on the CLI, including help and error messages.

To Reproduce
Steps to reproduce the behavior:

  1. Audit a url with PSAT CLI in verbose mode $ psat https://example.com -v
  2. Check the output message

Expected behavior
Clear message without typos

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS
  • Version PSAT CLI 0.10.1-1

Additional context
Add any other context about the problem here.

@fellyph fellyph self-assigned this Aug 19, 2024
@fellyph fellyph added the CLI label Aug 20, 2024
@maitreyie-chavan maitreyie-chavan added this to the v1.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants