Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI output typo and improve text #806

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Conversation

fellyph
Copy link
Collaborator

@fellyph fellyph commented Aug 14, 2024

Description

This pull request corrects some sentences on the output messages from the CLI and improves some sentences to make them clear

Relevant Technical Choices

Testing Instructions

  1. Open the CLI on the terminal
  2. Run a audit with verbose mode $ psat https://example.com -v
  3. Check the output messages

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #807

@fellyph fellyph changed the base branch from main to develop August 14, 2024 12:42
@fellyph fellyph marked this pull request as draft August 14, 2024 12:43
@fellyph fellyph requested review from mohdsayed and amovar18 August 19, 2024 15:10
@fellyph fellyph marked this pull request as ready for review August 20, 2024 07:47
@mohdsayed mohdsayed added this to the v1.0 milestone Aug 20, 2024
@mohdsayed mohdsayed merged commit 46f18c5 into develop Aug 20, 2024
6 checks passed
@mohdsayed mohdsayed deleted the fixing-cli-output-typo branch August 20, 2024 15:41
@milindmore22 milindmore22 mentioned this pull request Sep 2, 2024
32 tasks
@mohdsayed mohdsayed changed the title Fixing CLI output typo and improve text Fix CLI output typo and improve text Sep 18, 2024
@mohdsayed mohdsayed mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants