Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve helper message for the GDPR banner parameter #844

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Improve helper message for the GDPR banner parameter #844

merged 1 commit into from
Nov 18, 2024

Conversation

fellyph
Copy link
Collaborator

@fellyph fellyph commented Sep 25, 2024 •
edited by mohdsayed
Loading

Description

This pull request is related to issue #843, updating the helper message for the option --button-selectors

Relevant Technical Choices

Standardize the name convention for the technologies listed and use better wording on the CLI messages.

Testing Instructions

  1. install PSAT CLI
  2. Run the command npm run cli -- -h
  3. Check the message

Additional Information:

Screenshot/Screencast

Screenshot 2024-09-25 at 15 25 01

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #843

@milindmore22 milindmore22 changed the base branch from main to develop November 18, 2024 07:16
milindmore22
milindmore22 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@milindmore22 milindmore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@mohdsayed mohdsayed added this to the v0.12 milestone Nov 18, 2024
@mohdsayed mohdsayed merged commit cf6c0a6 into develop Nov 18, 2024
4 checks passed
@mohdsayed mohdsayed deleted the cli/improve-gdpr-banner-message branch November 18, 2024 13:58
amovar18 pushed a commit that referenced this pull request Dec 12, 2024
@fellyph @amovar18
updating CLI message (#844)
c7bf79d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

@milindmore22 milindmore22 milindmore22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12
Development

Successfully merging this pull request may close these issues.

Improve CLI helper message
3 participants
@fellyph @milindmore22 @mohdsayed