Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve helper message for the GDPR banner parameter #844

Merged
merged 1 commit into from
Nov 18, 2024
+2 −2
Merged

Improve helper message for the GDPR banner parameter #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Options:
-c, --concurrency <num> Number of tabs to open in parallel during sitemap or CSV analysis (default: 3)
-w, --wait <num> Number of milliseconds to wait after the page is loaded before generating the report (default: 20000)
-l, --locale <language> Locale to use for the CLI, supported: en, hi, es, ja, ko, pt-BR (default: "en")
-b, --button-selectors <path> The path to a json file which contains selectors or button text to be used for GDPR banner acceptance
-b, --button-selectors <path> The path to a JSON file that contains selectors or button text to be used for GDPR banner acceptance
-h, --help Display help for command
To learn more, visit our wiki: https://github.com/GoogleChromeLabs/ps-analysis-tool/wiki.
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
)
.option(
'-b, --button-selectors <path>',
'The path to a json file which contains selectors or button text to be used for GDPR banner acceptance',
'The path to a JSON file that contains selectors or button text to be used for GDPR banner acceptance',
(value) => filePathValidator(value, '-b')
)
.helpOption('-h, --help', 'Display help for command')
Expand Down Expand Up @@ -236,7 +236,7 @@
text: 'Analyzing cookies on the first site visit',
});

let cookieAnalysisAndFetchedResourceData: any;

Check warning on line 239 in packages/cli/src/index.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type

// eslint-disable-next-line no-useless-catch -- Because we are rethrowing the same error no need to create a new Error instance
try {
Expand Down
Loading