Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Commit

Permalink
Merge pull request #254 from GoogleCloudPlatform/update_material
Browse files Browse the repository at this point in the history
Update Angular Material to v1.0.5
  • Loading branch information
jmuharsky committed Mar 8, 2016
2 parents 394f481 + 3f4291c commit 2f3f433
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 23 deletions.
6 changes: 3 additions & 3 deletions bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"author": "Joe Allan Muharsky <[email protected]>",
"dependencies": {},
"devDependencies": {
"angular": "~1.4.8",
"angular": "~1.4.9",
"angular-bootstrap": "~0.14.3",
"angular-material": "~0.10.1",
"angular-mocks": "~1.4.8",
"angular-material": "~1.0.5",
"angular-mocks": "~1.4.9",
"angular-ui-router": "~0.2.15",
"angular-ui-grid": "~3.0.7",
"bootstrap-css-only": "~3.3.5",
Expand Down
2 changes: 1 addition & 1 deletion client/components/dashboard/dashboard-config-directive.css
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
}

.checkbox-row-checkbox {
padding-top: 4px;
padding-top: 7px;
padding-right: 2px;
}

Expand Down
12 changes: 6 additions & 6 deletions client/components/dashboard/dashboard-directive.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<div class="spinner" ng-show="explorerSvc.model.dashboardIsLoading"></div>

<div ng-repeat="container in dashboardSvc.containers"
class="pk-container pk-container-{{ container.model.id }} pk-background"
ng-class="getSelectedClass(container)">
class="pk-container pk-background"
ng-class="['pk-container-' + container.model.id, getSelectedClass(container)]">

<container class="pk-container-content" layout="column"
ng-model="container.model"
Expand All @@ -20,7 +20,7 @@
ng-repeat="widget in container.model.container.children"
widget-config="widget"
flex="{{ getWidgetFlexWidth(widget, container) }}"
layout="columns">
layout="column">
<div class="pk-widget-toolbar">
<span class="glyphicon glyphicon-remove pk-widget-button"
ng-hide="explorerSvc.model.readOnly"
Expand All @@ -46,14 +46,14 @@
ng-style="{'height': container.model.container.widget_header_height + 'px'}"
markdown-to-html="(widget.model.header_text || '') | stripHtml">
</div>
<div class="pk-widget-content"
<div class="pk-widget-content" flex layout="column"
ng-style="{height: isWidgetScrollable(widget, container) ? container.model.container.height + 'px' : 'auto',
'min-height': container.model.container.height + 'px',
'overflow-y': isWidgetScrollable(widget, container) ? 'auto' : 'visible'}"
ng-click="clickWidget($event, widget, container)">
<gviz-chart-widget widget-config="widget"
<gviz-chart-widget widget-config="widget" flex
ng-if="widget.model.type == widgetFactorySvc.widgetTypes.CHART"></gviz-chart-widget>
<div class="pk-widget-section-text"
<div class="pk-widget-section-text" flex
ng-if="widget.model.type == widgetFactorySvc.widgetTypes.TEXT"
ng-show="widget.model.datasource.text"
markdown-to-html="widget.model.datasource.text | stripHtml">
Expand Down
6 changes: 3 additions & 3 deletions client/components/widget/data_viz/gviz/gviz-directive.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div>
<div class="pk-conditional" ng-class="getWidgetStatusClass()">
<div layout="column" flex>
<div class="pk-conditional" ng-class="getWidgetStatusClass()" layout="column" flex>
<div class="pk-if pk-cond-nodata pk-chart-nodata">
No data available.
</div>
Expand All @@ -11,7 +11,7 @@
<div class="pk-if pk-cond-fetching pk-chart-loading md-primary md-hue-3">
<md-progress-circular md-mode="indeterminate"></md-progress-circular>
</div>
<div class="pk-if pk-cond-fetched pk-chart">
<div flex class="pk-if pk-cond-fetched pk-chart">
</div>
<div class="pk-if pk-cond-error pk-chart-error">
{{ widgetConfig.state().chart.error }}
Expand Down
11 changes: 5 additions & 6 deletions client/components/widget/data_viz/gviz/gviz-directive.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ explorer.components.widget.data_viz.gviz.gvizChart = function(

chartWrapper.setDataTable(data);

adjustHeight();
adjustWidth();

// Force height and width options value with state value
options.height = scope.widgetConfig.state().chart.height;
options.width = scope.widgetConfig.state().chart.width;
Expand Down Expand Up @@ -227,12 +230,8 @@ explorer.components.widget.data_viz.gviz.gvizChart = function(

let adjustWidth = function() {
if (scope.widgetConfig.model.chart) {
if (isWidthEnforced()) {
scope.widgetConfig.state().chart.width =
element.parent().prop('offsetWidth') - 1;
} else {
scope.widgetConfig.state().chart.width = null;
}
scope.widgetConfig.state().chart.width =
element.parent().prop('offsetWidth') - 1;
}
};
adjustWidth();
Expand Down
1 change: 1 addition & 0 deletions client/components/widget/widget-directive.css
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
.pk-widget-content {
background: #ffffff;
overflow-y: auto;
overflow-x: auto;
}

.pk-container {
Expand Down
5 changes: 2 additions & 3 deletions client/components/widget/widget-directive.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<div flex
<div flex layout="column"
ng-class="{'pk-widget-selected': widgetConfig.state().selected}">
<div class="pk-widget-body {{ widgetConfig.model.layout.cssClasses }}"
ng-transclude>
<div class="pk-widget-body" layout="column" flex ng-transclude>
</div>
</div>
2 changes: 1 addition & 1 deletion lib/closure-library
Submodule closure-library updated 1264 files

0 comments on commit 2f3f433

Please sign in to comment.