Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alerts, Logging, Channels Factories #2758
base: master
Are you sure you want to change the base?
Add Alerts, Logging, Channels Factories #2758
Changes from 10 commits
6a8ae06
2586c54
4e9f75e
5b768a3
9ba92c3
4e8a745
8f16176
44b0bcc
82831ab
f72d382
a81081a
c5f25d0
38bf7f3
a832ddb
91e4974
0704848
f1ed65d
c674b6c
fc3f5a6
da1274d
5cc77a6
d922bbf
17a1777
ab0b017
248f4d2
1d43499
832bfee
c253ef2
c88821d
c442495
05cecc3
1f998b5
6b30b0d
b0eec9f
2789313
2c3615f
3049cc7
1ca9b09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should go in globals, but TBH I would not even pass this down as it's specific to stage 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we export notification channels to the following stages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use the existing
essential_contacts
email here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a similar thought either using an existing group, or building something with
var.organization.domain
I actually prefer using
essential_contacts