New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Correct the server and client certificates used in dialer_test.go #933

Open

hessjcg wants to merge 1 commit into main from gh-932-test-certs

Contributor

hessjcg commented Jan 31, 2025

Update the dialer_test and other tests to use more accurate certificate validation logic. This improves the tests in these ways:

The tests now do full mTLS verification.
The certificates used in the tests accurately reproduce the structure of the real certificates used by Cloud SQL
The complex certificate logic is now consolidated into internal/mock/certs.go

Part of #932

hessjcg force-pushed the gh-932-test-certs branch 4 times, most recently from 3a7c320 to d237673 Compare

January 31, 2025 22:39

hessjcg marked this pull request as ready for review

January 31, 2025 22:40

hessjcg requested a review from a team as a code owner

January 31, 2025 22:40

blunderbuss-gcf bot assigned jackwotherspoon


          test: Correct the server and client certificates used in dialer_test.go

1d5dd2e

hessjcg force-pushed the gh-932-test-certs branch from d237673 to 1d5dd2e Compare

January 31, 2025 22:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet