feat(SQLAdminFetcher): Support base AuthClient for auth and loginAuth
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbankhead
commented
Oct 23, 2023
| this.client = new Sqladmin({ | ||
| rootUrl: sqlAdminAPIEndpoint, | ||
| auth, | ||
| auth: auth as GoogleAuth, |
There was a problem hiding this comment.
Requires the following to be resolved in order to remove the casting:
danielbankhead
commented
Oct 23, 2023
| @@ -71,6 +71,28 @@ const mockRequest = ( | |||
| }); | |||
| }; | |||
|
|
|||
| t.test('constructor', async t => { | |||
There was a problem hiding this comment.
These tests aren't really 'tested' as this suite may be refactored shortly; they only exist for coverage purposes.
edosrecki
suggested changes
Oct 28, 2023
danielbankhead
commented
Nov 6, 2023
ruyadorno
approved these changes
Nov 13, 2023
ruyadorno
force-pushed
the
support-base-auth-client
branch
from
30d140e to
4ee3557
Compare
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Adds custom auth support for
authandloginAuth.Checklist
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea.
Relevant issues: