feat: add support for custom user agent #410
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom user agent via user agent comments.
HTTP user agent's take the form of
<product> / <product-version> <comment>
Previously, we did not allow support for the
comment
field, leaving no wayto customize a user agent:
cloud-sql-nodejs-connector/src/sqladmin-fetcher.ts
Lines 110 to 114 in 5bbd6be
This PR changes that by adding
userAgent
as a supportedConnectorOptions
which will be passed and used to set the
comment
field, allowing customizationsto the user agent.
Closes: #401
Ref: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent