chore(all): update opentelemetry-go-contrib monorepo #4902
Conversation
|
product-auto-label
bot
added
the
samples
![code-review-assist[bot]](https://avatars.githubusercontent.com/in/1008254?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi team,
I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary for you and other reviewers to get up to speed:
This pull request, submitted by Renovate, updates several OpenTelemetry Go contrib packages to their latest versions. The goal is to keep the golang-samples repository using the most up-to-date and secure versions of these libraries. This is a dependency update PR, and therefore no functional changes are expected.
Here's a breakdown of the changes:
-
Updated Packages:
go.opentelemetry.io/contrib/detectors/gcp: Updated fromv1.28.0tov1.33.0go.opentelemetry.io/contrib/exporters/autoexport: Updated fromv0.53.0tov0.58.0go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp: Updated fromv0.53.0tov0.58.0go.opentelemetry.io/contrib/propagators/autoprop: Updated fromv0.53.0tov0.58.0
-
Affected Files: The changes are reflected in the
go.modfiles within theopentelemetry/instrumentation/appandopentelemetry/tracedirectories. Specifically, the version numbers for the listed packages are updated within these files.
The full release notes for the updated opentelemetry-go-contrib monorepo are quite extensive and included in the PR description. I recommend reviewing them for a complete picture of all changes in the underlying libraries.
And now, a little haiku to lighten the mood:
Dependencies flow,
New versions, fresh and clean code,
Smooth sailing ahead.
Thanks,
Gemini
There was a problem hiding this comment.
This pull request updates several packages in the opentelemetry-go-contrib monorepo. It's good practice to keep dependencies up-to-date, and the provided table in the description is helpful for understanding the changes at a high level. The release notes are extensive and provide good context. However, consider summarizing the key changes and their potential impact on the project in the PR description itself. This will make it easier for reviewers to quickly assess the importance and risk of the update.
I've studied the release notes and the diff hunks and offer the following suggestions.
| go.opentelemetry.io/contrib/exporters/autoexport v0.58.0 | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0 | ||
| go.opentelemetry.io/contrib/propagators/autoprop v0.58.0 |
There was a problem hiding this comment.
Updating these opentelemetry-go-contrib packages is a good step. Could you elaborate in the PR description on why these specific versions were chosen? For example, are there any new features or bug fixes that are particularly relevant to this project? Referencing specific issues or sections of the release notes would be helpful. Additionally, it's important to consider the impact of dependency updates on the project's overall stability and performance. Are there any breaking changes introduced by these new versions? How do these updates affect the size and performance of the application?
| @@ -6,7 +6,7 @@ require ( | |||
| cloud.google.com/go/trace v1.10.10 | |||
| github.com/GoogleCloudPlatform/golang-samples v0.0.0-20240724083556-7f760db013b7 | |||
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace v1.24.1 | |||
| go.opentelemetry.io/contrib/detectors/gcp v1.28.0 | |||
| go.opentelemetry.io/contrib/detectors/gcp v1.33.0 | |||
There was a problem hiding this comment.
The update to go.opentelemetry.io/contrib/detectors/gcp from v1.28.0 to v1.33.0 is significant. The release notes mention several changes, including added support for SNS instrumentation and fixes for AWS presigned URLs and OTLP exporter configuration. It's important to ensure that these changes don't introduce any regressions in the project. Do you have any tests in place to verify the behavior of the GCP resource detector after this update? Specifically, it would be beneficial to add tests that cover the following scenarios:
- Verify that the resource detector correctly identifies the GCP environment.
- Ensure that the expected resource attributes are being collected.
- Confirm that no unexpected attributes are being added.
- Test any new functionality introduced in the updated version, such as SNS instrumentation support.
Consider adding these tests to the opentelemetry/trace/main_test.go file.
This PR contains the following updates:
v1.28.0->v1.33.0v0.53.0->v0.58.0v0.53.0->v0.58.0v0.53.0->v0.58.0Release Notes
open-telemetry/opentelemetry-go-contrib (go.opentelemetry.io/contrib/detectors/gcp)
v1.33.0: /v0.58.0/v0.27.0/v0.13.0/v0.8.0/v0.6.0/v0.5.0Compare Source
Overview
Added
endpoint,pollingIntervalMsandinitialSamplingRateusing environment variableOTEL_TRACES_SAMPLER_ARGingo.opentelemetry.io/contrib/samples/jaegerremote. (#6310)go.opentelemetry.io/contrib/config. (#6340)go.opentelemetry.io/contrib/bridges/otellogrmodule.This module provides an OpenTelemetry logging bridge for
github.com/go-logr/logr. (#6386)go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws. (#6388)Changed
GET /pathso it complies with the OTel HTTP semantic conventions ingo.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho. (#6365)gin.errorsattribute ingo.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin. (#6346)go.opentelemetry.io/contrib/confignow supports multiple schemas in subdirectories (i.e.go.opentelemetry.io/contrib/config/v0.3.0) for easier migration. (#6412)Fixed
go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws. (#5975)grpcinstead ofgrpc/protobufingo.opentelemetry.io/contrib/config. (#6338)go.opentelemetry.io/contrib/config. (#6347)HTMLfunction ingo.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin. (#6373)code.functionattribute emitted bygo.opentelemetry.io/contrib/bridges/otelslognow stores just the function name instead the package path-qualified function name. Thecode.namespaceattribute now stores the package path. (#6415)code.functionattribute emitted bygo.opentelemetry.io/contrib/bridges/otelzapnow stores just the function name instead the package path-qualified function name. Thecode.namespaceattribute now stores the package path. (#6423)What's Changed
e0fbfb7by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/632465e8d21by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6325e639e21by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6344e639e21by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/63459959940by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/63772c02b82by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/638319429a9by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6393a4fef06by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6410e6fa225by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/641324370beby @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/64161443442by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/64171829a12by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/64215ad02ceby @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6432New Contributors
Full Changelog: open-telemetry/opentelemetry-go-contrib@v1.32.0...v1.33.0
v1.32.0: /v0.57.0/v0.26.0/v0.12.0/v0.7.0/v0.5.0/v0.4.0Compare Source
Overview
Added
WithSourceoption to thego.opentelemetry.io/contrib/bridges/otelsloglog bridge to set thecode.*attributes in the log record that includes the source location where the record was emitted. (#6253)ContextWithStartTimeandStartTimeFromContexttogo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp, which allows setting the start time using go context. (#6137)code.*attributes ingo.opentelemetry.io/contrib/bridges/otelzapif thezap.Loggerwas created with theAddCallerorAddStacktraceoption. (#6268)LogProcessortogo.opentelemetry.io/contrib/processors/baggagecopyto copy baggage members to log records. (#6277)baggagecopy.NewLogProcessorwhen configuring a Log Provider.NewLogProcessoraccepts aFilterfunction type that selects which baggage members are added to the log record.Changed
slog.KindAny) attribute values to matchinglog.Valuetypes.For example,
[]string{"foo", "bar"}attribute value is now transformed tolog.SliceValue(log.StringValue("foo"), log.StringValue("bar"))instead oflog.String("[foo bar"]). (#6254)go.opentelemetry.io/otel/semconv/v1.17.0togo.opentelemetry.io/otel/semconv/v1.21.0ingo.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo. (#6272)go.opentelemetry.io/contrib/config. (#6289)Fixed
log.Valuezero value instead of panicking ingo.opentelemetry.io/contrib/bridges/otellogrus. (#6237)log.Valuezero value instead of panicking ingo.opentelemetry.io/contrib/bridges/otelzap. (#6237)log.Valuezero value instead oflog.StringValue("<nil>")ingo.opentelemetry.io/contrib/bridges/otelslog. (#6246)NewClientHandlerso thatrpc.client.request.*metrics measure requests instead of responses andrpc.client.responses.*metrics measure responses instead of requests ingo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. (#6250)go.opentelemetry.io/contrib/configcausingotelprom.WithResourceAsConstantLabelsconfiguration to not be respected. (#6260)otel.Handleis no longer called on a successful shutdown of the Prometheus exporter ingo.opentelemetry.io/contrib/config. (#6299)What's Changed
796eee8by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6257324edc3by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/62703ea5e8cby @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6290dd2ea8eby @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/62926fe5fd8by @renovate in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6291New Contributors
Full Changelog: open-telemetry/opentelemetry-go-contrib@v1.31.0...v1.32.0
v1.31.0: /v0.56.0/v0.25.0/v0.11.0/v0.6.0/v0.4.0/v0.3.0Compare Source
Overview
Added
SeveritierandSeverityVartypes are added togo.opentelemetry.io/contrib/processors/minsevallowing dynamic configuration of the severity used by theLogProcessor. (#6116)go.opentelemetry.io/otelto this repository underexamplesdirectory. (#6158)go.opentelemetry.io/contrib/config. (#5433)ParseYAMLingo.opentelemetry.io/contrib/config. (#5433)go.opentelemetry.io/contrib/config. (#5860)Changed
NewLogProcessoringo.opentelemetry.io/contrib/processors/minsevhas changed to accept the addedSeveritierinterface instead of alog.Severity. (#6116)go.opentelemetry.io/contrib/configto use the v0.3.0 release of schema which includes backwards incompatible changes. (#6126)NewSDKingo.opentelemetry.io/contrib/confignow returns a no-op SDK ifdisabledis set totrue. (#6185)go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelechopackage has found a Code Owner. The package is no longer deprecated. (#6207)Fixed
Configuration
📅 Schedule: Branch creation - "* 0-3 * * 1" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.