Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong tag correction #4903

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

BigBlackWolf
Copy link

Description

The tag differs from file name. Correcting the region tag to be consistent with the sample.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request, submitted by BigBlackWolf, aims to fix an inconsistency between a file name and its associated tag. Specifically, the tag compute_instance_attach_regional_disk_force was incorrect and has been updated to compute_instance_create_replicated_boot_disk to accurately reflect the sample's functionality.

Here's a breakdown of the changes:

  • File Changed: compute/instances/create-start-instance/create_instance_with_replicated_boot_disk.go
  • Changes: The PR modifies lines 17 and 92 of this file. The incorrect tag compute_instance_attach_regional_disk_force is replaced with the correct tag compute_instance_create_replicated_boot_disk both at the beginning and end of the file. This ensures consistency and clarity in the code.

The intent is to improve the accuracy and maintainability of the code sample by correcting the misleading tag. The changes are straightforward and well-documented.


A little haiku to lighten the mood:

Tags aligned with grace,
Code flows clean, a joyful sight,
Review's swift embrace.

Thanks,
Gemini

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 23, 2024
Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@BigBlackWolf BigBlackWolf added the api: compute Issues related to the Compute Engine API. label Dec 23, 2024
@BigBlackWolf BigBlackWolf marked this pull request as ready for review December 23, 2024 13:44
@BigBlackWolf BigBlackWolf requested review from a team as code owners December 23, 2024 13:44
Copy link

snippet-bot bot commented Dec 23, 2024

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@BigBlackWolf BigBlackWolf enabled auto-merge (squash) December 23, 2024 13:45
@BigBlackWolf
Copy link
Author

@telpirion I've noticed a mistake in one sample PTAL.

Also this is my last PR to this repo. Thank you, for your suggestions and patience to my PRs all this time :)
It was a pleasure working with you!
Merry Christmas!

@BigBlackWolf BigBlackWolf merged commit 6fd2b11 into main Dec 29, 2024
11 checks passed
@BigBlackWolf BigBlackWolf deleted the fix_compute_instance_create_replicated_boot_disk branch December 29, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants