Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(speech): delete old region tag "imports" #4932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −2
Open

fix(speech): delete old region tag "imports" #4932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions speech/snippets/model_selection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,10 @@ import (
"strings"

// [START speech_transcribe_model_selection_imports]
// [START imports]
"context"

speech "cloud.google.com/go/speech/apiv1"
"cloud.google.com/go/speech/apiv1/speechpb"
Comment on lines 24 to 28
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The import statements cloud.google.com/go/speech/apiv1 and cloud.google.com/go/speech/apiv1/speechpb should be grouped together, per the Google Go Style Guide. Can you group these together? Here's a snippet from the style guide:

Imports should be grouped in the following order:

  1. Standard library imports
  2. Third-party imports
  3. Local application/library specific imports

I'm also seeing a similar issue in speech/snippets/enhanced_model.go, so I'd recommend fixing that as well.

// [END imports]
// [END speech_transcribe_model_selection_imports]
)

Expand Down
Loading