Merge pull request #2604 from balopat/v0350

cut v0.35.0

CHANGELOG.md

@@ -1,9 +1,50 @@
-# v0.XX.X Release - MM/DD/YYYY
+# v0.35.0 Release - 08/02/2019
 
 *Note for Jib users*: The Jib binding has changed and projects are now required to use
         Jib v1.4.0 or later.  Maven multi-module projects no longer require
         binding `jib:build` or `jib:dockerBuild` to the _package_ phase and should be removed.
 
+New Features:
+
+* Add Jib detection to skaffold init [#2276](https://github.com/GoogleContainerTools/skaffold/pull/2276)
+* Add ability to pass an explicit registry value to Helm charts [#2188](https://github.com/GoogleContainerTools/skaffold/pull/2188)
+
+Bug Fixes:
+
+* Make sure we mute/unmute logs at the correct times [#2592](https://github.com/GoogleContainerTools/skaffold/pull/2592)
+* Fix handling of whitelisted directories in dockerignore [#2589](https://github.com/GoogleContainerTools/skaffold/pull/2589)
+* Cleaner kubectl `port-forward` retry logic [#2593](https://github.com/GoogleContainerTools/skaffold/pull/2593)
+* Negotiate docker API version when creating minikube docker client [#2577](https://github.com/GoogleContainerTools/skaffold/pull/2577)
+* Retry port forwarding when we see forwarding-related errors from kubectl [#2566](https://github.com/GoogleContainerTools/skaffold/pull/2566)
+
+Updates & Refactors:
+
+* Refactor: Use new `kubectl.CLI` util to shell out to `kubectl` [#2509](https://github.com/GoogleContainerTools/skaffold/pull/2509)
+* Remove duplication around Go modules settings [#2580](https://github.com/GoogleContainerTools/skaffold/pull/2580)
+* Faster tests [#2570](https://github.com/GoogleContainerTools/skaffold/pull/2570)
+* [linters] Use vendored dependencies. Don’t download them. [#2579](https://github.com/GoogleContainerTools/skaffold/pull/2579)
+* Improve Jib support on gcb [#2548](https://github.com/GoogleContainerTools/skaffold/pull/2548)
+* Bring back applying labels to services deployed with helm [#2568](https://github.com/GoogleContainerTools/skaffold/pull/2568)
+* Fix linter deadline [#2572](https://github.com/GoogleContainerTools/skaffold/pull/2572)
+* Go Modules [#2541](https://github.com/GoogleContainerTools/skaffold/pull/2541)
+* Make all embedded fields on runner private [#2565](https://github.com/GoogleContainerTools/skaffold/pull/2565)
+* Simplify FakeAPIClient [#2563](https://github.com/GoogleContainerTools/skaffold/pull/2563)
+* Minor changes to kubectl and kustomize deployers [#2537](https://github.com/GoogleContainerTools/skaffold/pull/2537)
+* Simplify Sync code [#2564](https://github.com/GoogleContainerTools/skaffold/pull/2564)
+* Starting a refactoring around RunContext and Docker local/remote Api [#2497](https://github.com/GoogleContainerTools/skaffold/pull/2497)
+
+Huge thanks goes out to all of our contributors for this release:
+
+- Balint Pato
+- Cornelius Weig
+- David Gageot
+- Michael Beaumont
+- Nick Kubala
+- Priya Wadhwa
+- Tad Cordle
+- Tejal Desai
+
+
 
 # v0.34.1 Release - 07/25/2019
 This minor release addresses [#2523](https://github.com/GoogleContainerTools/skaffold/issues/2523), a

examples/jib-multimodule/pom.xml

@@ -18,6 +18,7 @@
 
   <properties>
     <java.version>1.8</java.version>
+    <jib.maven-plugin-version>1.4.0</jib.maven-plugin-version>
   </properties>
 
   <dependencies>
@@ -38,7 +39,7 @@
         <plugin>
           <groupId>com.google.cloud.tools</groupId>
           <artifactId>jib-maven-plugin</artifactId>
-          <version>1.4.0</version>
+          <version>${jib.maven-plugin-version}</version>
         </plugin>
       </plugins>
     </pluginManagement>

examples/jib-multimodule/project1/pom.xml

@@ -36,16 +36,6 @@
                         </jvmFlags>
                     </container>
                 </configuration>
-                <executions>
-                    <!-- Skaffold multi-module with Jib requires a jib:xxx goal be bound to the package phase -->
-                    <execution>
-                        <id>default-package</id>
-                        <phase>package</phase>
-                        <goals>
-                            <goal>build</goal>
-                        </goals>
-                    </execution>
-                </executions>
             </plugin>
         </plugins>
     </build>

examples/jib-multimodule/project2/pom.xml

@@ -36,16 +36,6 @@
                         </jvmFlags>
                     </container>
                 </configuration>
-                <executions>
-                    <!-- Skaffold multi-module with Jib requires a jib:xxx goal be bound to the package phase -->
-                    <execution>
-                        <id>default-package</id>
-                        <phase>package</phase>
-                        <goals>
-                            <goal>build</goal>
-                        </goals>
-                    </execution>
-                </executions>
             </plugin>
         </plugins>
     </build>

examples/jib/pom.xml

@@ -9,6 +9,7 @@
 
     <properties>
         <java.version>1.8</java.version>
+        <jib.maven-plugin-version>1.4.0</jib.maven-plugin-version>
     </properties>
 
     <parent>
@@ -34,7 +35,7 @@
             <plugin>
                 <groupId>com.google.cloud.tools</groupId>
                 <artifactId>jib-maven-plugin</artifactId>
-                <version>1.4.0</version>
+                <version>${jib.maven-plugin-version}</version>
                 <configuration>
                     <container>
                         <jvmFlags>

examples/react-reload/skaffold.yaml

@@ -5,6 +5,8 @@ build:
   - image: gcr.io/k8s-skaffold/react-reload
     context: app
     sync:
-      infer:
-      - 'src/components/*'
-      - 'src/styles/*'
+      manual:
+      - src: 'src/components/*'
+        dest: .
+      - src: 'src/styles/*'
+        dest: .