#770 HTTP support #777
#770 HTTP support #777
Conversation
StephanMeijer
force-pushed
the
http-770
branch
from
d2eca30 to
5b3ed16
Compare
StephanMeijer
force-pushed
the
http-770
branch
from
5b3ed16 to
b8f4027
Compare
|
Please merge #778 first/ |
| @@ -72,3 +72,4 @@ Contributors | |||
| - BinaryBabel (contributed support for YouTrack) | |||
| - Matthew Cengia (contributed extra support for Trello) | |||
| - Andrew Demas (contributed support for PivotalTracker) | |||
| - Stephan Meijer (contributed support for JIRA, Zepel, GMail and HTTP) | |||
There was a problem hiding this comment.
The context of the way we've been using this list suggests that you were the originall/primary contributor of the gmail and jira services.
|
|
||
| .. code:: bash | ||
|
|
||
| pip install bugwarrior[http] |
There was a problem hiding this comment.
There don't appear to be any extra dependencies required for this service.
| ++++++++++++++ | ||
|
|
||
| +--------------------------------+---------------------------------------------------------------------------------+ | ||
| | ``http.method`` | HTTP method to use, such as GET or POST. | |
There was a problem hiding this comment.
Why support methods other than GET? We're very rigid about the body format we accept so why be flexible about the http methd?
There was a problem hiding this comment.
Body format is harder to make flexible, I would have done so if easily possible.
There was a problem hiding this comment.
But what other http method than GET could possibly be appropriate for fetching an array of tasks?
|
|
||
| self.assertTrue(MAX_TASK in issues) | ||
| self.assertEqual(issues[1], MIN_TASK) | ||
| """ |
There was a problem hiding this comment.
This comment block appears to be accidentally committed.
| 'uuid', | ||
| self.extra.get('url') | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Seems like the description field is a required return value by the http service so why do we need these fallbacks?
|
|
||
|
|
||
| class HttpService(IssueService): | ||
| APPLICATION_NAME = 'Bugwarrior HTTP Service' |
There was a problem hiding this comment.
What is the APPLICATION_NAME attribute for?
There was a problem hiding this comment.
I don't know, will remove
| } | ||
| ] | ||
|
|
||
| Possibly other attributes such as annotations or priority will be implemented later on. |
There was a problem hiding this comment.
I think adding an explicit list of required keys to this section would be helpful.
No description provided.