feat: add bold color with 256 color space #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason that bold cannot work in 256 color space. Perhaps initially this was disabled due to old terminals not supporting this behavior. But in 2024 there is no reason to disable bold.
The expected result for upgrade 'bold red on ...' should now be 'bold color 1 on ...'.
djmitche
approved these changes
Oct 23, 2024
lauft
approved these changes
Oct 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason that bold cannot work in 256 color space. Perhaps initially this was disabled due to old terminals not supporting bold and 256 control codes. But in 2024 there is no reason to disable bold.
This PR fixes this and allows users to use bold in themes no matter whether 256 color or 16 color space is used.