Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Class-Path in shadowed Gradle plugin jar #1149

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Jan 12, 2025

Refs #852.

@Goooler Goooler force-pushed the g/20250111/assert-shadowed-plugin-jar branch 2 times, most recently from 33d58ad to 27859c5 Compare January 12, 2025 07:19
@Goooler Goooler changed the title Check Class-Path for shadowed Gradle plugin jar Check Class-Path in shadowed Gradle plugin jar Jan 12, 2025
@Goooler Goooler force-pushed the g/20250111/assert-shadowed-plugin-jar branch from 27859c5 to 421d2c4 Compare January 12, 2025 08:24
@Goooler Goooler enabled auto-merge (squash) January 12, 2025 08:24
@Goooler Goooler merged commit 96fe2fe into main Jan 12, 2025
7 checks passed
@Goooler Goooler deleted the g/20250111/assert-shadowed-plugin-jar branch January 12, 2025 08:28
transform { it.manifest.mainAttributes.keys }.all {
isNotEmpty()
// Doesn't contain Gradle classes.
doesNotContain("Class-Path")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not work properly. The key set is Set<Object> instead of Set<String>.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing in #1161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant