Add box selection modes for Touched/Contained/By Drag Direction #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
reviewed
Dec 23, 2024
|
I'll mark this as a draft until you've also added this to the user preferences dialog, with a choice between "Touched", "Contained", and "By Drag Direction". Please mark it as Ready for Review and ping me when that's ready. Thanks! |
Keavon
changed the title
added 8 commits
December 24, 2024 12:09
|
|
There's a merge conflict, please resolve that and I'll get to QA and code review after that. |
|
@Keavon please check now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2041
is_layer_fully_insideto determine if a layer is fully inside a selection box or not which will eventually helps to select objects in rightward direction.