fix: conjugation error in matvis wrapper #301
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is finished, but I wanted to at least get a start on it since I had kept punting on it. There are a few issues I'd still like to address, but I'm a bit too tired today to write good code, so I'll just note the things here:
blt_order
may have changed from('time', 'ant1')
to something like('time', 'baseline')
. This is functionally the same, but the different name means the bigif
clause (~line 420 inmatvis.py
) will be skipped when it shouldn't.('time', 'ant2')
ordering by taking the upper triangular indices of the visibility matrix.