Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conjugation error in matvis wrapper #301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

r-pascua
Copy link
Contributor

@r-pascua r-pascua commented Mar 4, 2024

I don't think this is finished, but I wanted to at least get a start on it since I had kept punting on it. There are a few issues I'd still like to address, but I'm a bit too tired today to write good code, so I'll just note the things here:

  • I think the default blt_order may have changed from ('time', 'ant1') to something like ('time', 'baseline'). This is functionally the same, but the different name means the big if clause (~line 420 in matvis.py) will be skipped when it shouldn't.
  • I think we can also populate the visibility matrix quickly with ('time', 'ant2') ordering by taking the upper triangular indices of the visibility matrix.
  • I would like to write some tests that appeal to the simulated visibilities to ensure the conjugation convention is correct. Here are two relatively simple ideas I have:
    • Single frequency, roughly an hour or so obstime with a small array, with a single source transiting zenith. Check that the fringe-rate transform (using a FFT and not an iFFT) peaks at positive fringe-rates.
    • Single time, roughly ten-ish MHz with a small array, with a single source somewhere overhead. We should be able to analytically calculate the delay spectrum peak for a given antenna conjugation.

@r-pascua r-pascua requested a review from steven-murray March 4, 2024 18:35
@r-pascua r-pascua self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant