-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin starter package #317
base: master
Are you sure you want to change the base?
Conversation
Would love to hear @nmalaguti thoughts on this implementation |
It looks like a lot of this is from the Java -> Kotlin autoconversion. It doesn't use a lot of Kotlin idioms. Example: for (b in 0..width - 1) {
row.add(Integer.parseInt(input[index]))
index++
} would be better as for (b in 0 until width) {
row.add(Integer.parseInt(input[index]))
index++
}
// or you could do something like
input.take(width).map { Integer.parseInt(it) } Also might want to use |
Does it look better now? |
Much! I think the package should include details on how to create a JAR with the Kotlin runtime included and a It should also include a |
We can include a Kotlin compiler on the server and properly tag Kotlin bots with the name "Kotlin." It is still nice to have the |
Not sure what is LANGUAGE(just txt with "Kotlin" inside?) file and where it should be. executable JAR file can be created with:
and simple run with: |
Yes. See "Customizing your language name" in this doc.
That would be great. |
The CI tests are failing because starter packs are assumed to be valid submissions with a |
Added kotlin language package. Kotlin compiler can be installed from https://github.com/JetBrains/kotlin/releases/latest