Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oneplus2 manifest #89

Merged
merged 2 commits into from
May 20, 2018
Merged

Add oneplus2 manifest #89

merged 2 commits into from
May 20, 2018

Conversation

Vince1171
Copy link
Member

add oneplus2 manifest for halium-7.1

@Vince1171
Add oneplus2 manifest
201433c 
add oneplus2 manifest for halium-7.1
@Vince1171 Vince1171 mentioned this pull request May 20, 2018
Open
35 tasks
jbruechert
jbruechert requested changes May 20, 2018
View reviewed changes
Copy link
Member

@jbruechert jbruechert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please format your manifest in the same coding style as the others? You can also drop the revision="cm-14.1" in the project tags, since it's set in the remote already.

@vanyasem
Copy link
Member

@jbbgameich fixed the issues

@jbruechert
Copy link
Member

Thank you!

@jbruechert jbruechert merged commit fd29d3d into Halium:halium-7.1 May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbruechert jbruechert jbruechert requested changes

@vanyasem vanyasem vanyasem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vince1171 @vanyasem @jbruechert