Skip to content

Commit

Permalink
fix label bug, toggle-event-label-on should not care about z-ndex
Browse files Browse the repository at this point in the history
  • Loading branch information
mudhoney authored and dgarciabriseno committed May 7, 2024
1 parent 1e456bd commit 95732cb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion resources/js/Events/EventManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ var EventManager = Class.extend({
// this is an frm
if(parts.length == 2) {
markersToEmphasize = this._eventMarkers.filter(em => {
return em.belongsToFrm(parts[1])
return em.belongsToFrm(parts[1]);
});
}

Expand Down
4 changes: 1 addition & 3 deletions resources/js/Events/EventMarker.js
Original file line number Diff line number Diff line change
Expand Up @@ -332,15 +332,13 @@ var EventMarker = Class.extend(
}

if ( event.type == 'toggle-event-label-on' ) {
this.eventMarkerDomNode.css('zIndex', '997');
this._labelVisible = true;
this._label.show();
Helioviewer.userSettings.set("state.eventLabels", true);
}
else if ( event.type == 'toggle-event-label-off' ) {
this._labelVisible = false;
this._label.hide();
this.eventMarkerDomNode.css('zIndex', this._zIndex);
Helioviewer.userSettings.set("state.eventLabels", false);
}
else if ( event.type == 'mouseenter' ) {
Expand All @@ -357,8 +355,8 @@ var EventMarker = Class.extend(
if ( !this._labelVisible) {
this._label.hide();
}
this._label.removeClass("event-label-hover");
this.eventMarkerDomNode.css('zIndex', this._zIndex);
this._label.removeClass("event-label-hover");

if(Helioviewer.userSettings.get("state.drawers.#hv-drawer-timeline-events.open") == true && timelineRes == 'm'){
$(".highcharts-series > rect").show();
Expand Down

0 comments on commit 95732cb

Please sign in to comment.