Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better zoom #525

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Conversation

dgarciabriseno
Copy link
Contributor

@dgarciabriseno dgarciabriseno commented Feb 5, 2024

Summary

Updates #519

  • Fixes smooth zooming with the mouse wheel.
  • Fixes centering the sun

Testing

Enter the browser versions this change was tested on below.

browser version
firefox 115.7
chrome 121.0.6167.139 (Official Build) (arm64)
safari Version 17.2.1 (18617.1.17.11.12, 18617)
edge 121.0.2277.98 (Official Build) (64-bit)

There are some issues on minimal/embed unrelated to this issue:

  • On edge, the + button on the zoom slider is offset.
  • There are two overlapping buttons in the minimal UI
  • Events are not showing in minimal/embed
    I'll open a new issue for these.

@dgarciabriseno dgarciabriseno merged commit 8584556 into Helioviewer-Project:main Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant