Added DeluxeMenusOpenMenuEvent and DeluxeMenusPreOpenMenuEvent
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oribuin
reviewed
Jan 22, 2024
| @@ -488,6 +495,11 @@ public void openMenu(final Player viewer, final Map<String, String> args, final | |||
| holder.startUpdatePlaceholdersTask(); | |||
| } | |||
| }); | |||
|
|
|||
| Bukkit.getScheduler().runTask(DeluxeMenus.getInstance(), () -> { | |||
There was a problem hiding this comment.
What's the purpose in doing this?
There was a problem hiding this comment.
So the event runs on the main thread, I think that is the preferable option here. Can be ran async though, see no problem with that. But the event name would have to include Async or note it in any other way.
|
Hey, any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
DeluxeMenusOpenMenuEventandDeluxeMenusPreOpenMenuEventBoth are useful for when you try to use other custom inventory plugins with DeluxeMenus.
(I myself needed this event, and it would be nice to not have to update the plugin manually myself each time you drop an update)