update for zig 0.13.0 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This pull request updates the codebase for zig 0.13.0.
std.json has changed considerably over the past couple years so with some of these changes I tried to keep a balance between using the new changes and keeping things simple.
The biggest examples of this are:
StringifyOptionschanged shape a lotThe
StringifyOptionschange is straightforward: I just grabbed the old version of it and inlined it so that the code in main.zig could use the same struct fields. Updating the stringify writeStream code to what's in 0.13.0 might take quite some time 😬About the formatting of floats: this is the only part of the pr that i have low confidence about, because it meant changing the expected values in the tests to what 0.13.0 outputs. I can make adjustments to the formatting if we find that my changes are incorrect.