Fixes for Windows on ARM #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows.h =/= windows.h on case-sensitive OSes/filesystems.
It doesn't even seem to be getting used by any of the AviSynth source files, at least on ARM, but if it is on x86(-64) then it should be special-cased for that architecture. Fixes a build error.
|
Why not using CMake? |
|
I'd been using the meson system that was already there, and hadn't had any problems thus far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case sensitivity and a couple of source files that seem like maybe they shouldn't be in the file list for AviSynth, as the only part of the project that appears to use
lwsimd.{c,h}is AviUtl.Technically, the lwsimd commit should also fix compiling the plugin on any OS running on non-x86(-64) architectures.