Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow-bot: disable #196746

Merged
merged 1 commit into from
Dec 30, 2024
Merged

shadow-bot: disable #196746

merged 1 commit into from
Dec 30, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Dec 30, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

The download URLs are unchanged, but require a sign query parameter:

Related to #172732 (comment)

@khipp khipp added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Dec 30, 2024
@BrewTestBot BrewTestBot added the cask disabled Cask disabled label Dec 30, 2024
@khipp khipp force-pushed the update-shadow-bot branch from a7934a9 to 47d97e5 Compare December 30, 2024 13:18
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'v also tried to find alternative but should be disabled now.

@daeho-ro daeho-ro merged commit 44535a7 into master Dec 30, 2024
9 checks passed
@daeho-ro daeho-ro deleted the update-shadow-bot branch December 30, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cask disabled Cask disabled ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants