fb303: add TODO for removal from synced_versions_formulae
#124433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm remove this from `synced_versions_formulae.json` in Homebrew#124347 since upstream seem to be missing a tag. Doing this allows us to update the other formulae in the meantime. However, let's add a note to add this back once upstream resolves the issue we filed about the missing tag. See facebook/fb303#34.
carlocab
added
the
CI-syntax-only
ZhongRuoyu
approved these changes
Feb 28, 2023
|
Let's wait to merge this until after #124347. Maybe there'll be a development upstream before then... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?I'm remove this from
synced_versions_formulae.jsonin #124347 sinceupstream seem to be missing a tag. Doing this allows us to update the
other formulae in the meantime.
However, let's add a note to add this back once upstream resolves the
issue we filed about the missing tag. See facebook/fb303#34.