Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-engine-java 1.9.59 #20250

Merged
merged 2 commits into from
Nov 7, 2017
Merged

app-engine-java 1.9.59 #20250

merged 2 commits into from
Nov 7, 2017

Conversation

pcavadas
Copy link
Contributor

@pcavadas pcavadas commented Nov 4, 2017

Created with brew bump-formula-pr.

@dunn
Copy link
Contributor

dunn commented Nov 7, 2017

@BrewTestBot test this please

@dunn
Copy link
Contributor

dunn commented Nov 7, 2017 

Error: app-engine-java: failed
Dev App Server terminated prematurely.
<nil> expected to not be nil.

@ilovezfs
Copy link
Contributor

ilovezfs commented Nov 7, 2017 •
edited
Loading

Same as the failure noted in #19696. It needs to have Java 8 specified via a wrapper script and depends_on :java => "1.8"

@ilovezfs ilovezfs added the java Java use is a significant feature of the PR or issue label Nov 7, 2017
@ilovezfs ilovezfs merged commit 8ec727e into Homebrew:master Nov 7, 2017
@ilovezfs
Copy link
Contributor

ilovezfs commented Nov 7, 2017

Thanks @cedla! Shipped!

@ilovezfs ilovezfs mentioned this pull request Nov 7, 2017
Closed
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
java Java use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcavadas @dunn @ilovezfs