Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] 2.11.12 #23413

Closed
wants to merge 2 commits into from
Closed

[email protected] 2.11.12 #23413

wants to merge 2 commits into from

Conversation

996refuse
Copy link
Contributor

Update scala 2.11.11 to 2.11.12

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Update scala 2.11.11 to 2.11.12
@queengooborg
Copy link
Contributor

Looks like your test is failing:

        Testing [email protected]
/usr/bin/sandbox-exec -f /tmp/homebrew20180129-58857-1fsyxvh.sb /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/bin/ruby -W0 -I /usr/local/Homebrew/Library/Homebrew -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/[email protected] --verbose
==> /usr/local/Cellar/[email protected]/2.11.12/bin/scala /tmp/[email protected]/Test.scala
cat: /release: No such file or directory
Picked up _JAVA_OPTIONS:  -Duser.home=/Users/brew/Library/Caches/Homebrew/java_cache
cat: /release: No such file or directory
Picked up _JAVA_OPTIONS:  -Duser.home=/Users/brew/Library/Caches/Homebrew/java_cache
error: Compile server encountered fatal condition: javax/tools/ToolProvider
Error: [email protected]: failed
<0> expected but was
<1>.

Can you please follow the checklist and confirm if it works on your local machine, or if not, fix the test so that it functions?

@ilovezfs
Copy link
Contributor

It's failing due to Java 9 as noted in #19696.

Also, with Java 8 there is a problem with this version.

iMac-TMP:~ joe$ /usr/local/opt/scala\@2.11/bin/scala Test.scala 
cat: /release: No such file or directory
4

@ilovezfs ilovezfs added the java Java use is a significant feature of the PR or issue label Jan 29, 2018
@996refuse
Copy link
Contributor Author

@vinyldarkscratch @ilovezfs
/usr/local/Cellar/[email protected]/2.11.12/bin/scala
Scala runner script trying to assume you have java 9 installed. And It looks like a regression bug.
scala/scala#5588.

Finally, I patch this to the script, and It works fine on my mac (os x 10.9.5 java 1.6.0_65) .

@ilovezfs
Copy link
Contributor

ilovezfs commented Feb 1, 2018

==> brew test [email protected] --verbose
==> FAILED
Testing [email protected]
/usr/bin/sandbox-exec -f /tmp/homebrew20180130-52674-1g8aqwh.sb /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby -W0 -I /usr/local/Homebrew/Library/Homebrew -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/[email protected] --verbose
==> /usr/local/Cellar/[email protected]/2.11.12/bin/scala /tmp/[email protected]/Test.scala
Picked up _JAVA_OPTIONS:  -Duser.home=/Users/brew/Library/Caches/Homebrew/java_cache
Picked up _JAVA_OPTIONS:  -Duser.home=/Users/brew/Library/Caches/Homebrew/java_cache
error: Compile server encountered fatal condition: javax/tools/ToolProvider
Error: [email protected]: failed
<0> expected but was
<1>.

@ilovezfs
Copy link
Contributor

ilovezfs commented Feb 9, 2018

Please feel free to open a fresh PR for this when it's working with Java 8 or Java 9.

@ilovezfs ilovezfs closed this Feb 9, 2018
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
java Java use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants