Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-cluster: require Java 8 specifically #28320

Merged
merged 1 commit into from
May 27, 2018
Merged

mysql-cluster: require Java 8 specifically #28320

merged 1 commit into from
May 27, 2018

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented May 27, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Addresses #19696 by requiring Java 8 specifically.

The brew test mysql-cluster is actually failing on my machine with this:

==> curl 127.0.0.1:3306
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   104    0   104    0     0  17983      0 --:--:-- --:--:-- --:--:-- 20800
Error: mysql-cluster: failed
</7\.5\.7/> expected to be =~
<"5.7.22\x00\x03\x00\x00\x00dmf&z\x06a:\x00\xFF\xFF!\x02\x00\xFF\xC1\x15\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00=\x10Foo%eJ\x01a5C\x00mysql_native_password\x00\e\x00\x00\x01\xFF\x84\x04Got packets out of order">.

But I'm hoping that out-of-order packet thing is just a fluke local to my machine (I have some other MySQL stuff installed which may well be conflicting with it), and the tests will work on the server. Sorry for using up test-bot time if this isn't the case.

@apjanke apjanke mentioned this pull request May 27, 2018
@ilovezfs ilovezfs added the java Java use is a significant feature of the PR or issue label May 27, 2018
@ilovezfs ilovezfs merged commit 1055f2c into Homebrew:master May 27, 2018
@ilovezfs
Copy link
Contributor

🚀

@apjanke apjanke deleted the mysql-cluster-jdk9-coexist branch May 27, 2018 15:49
@lock lock bot added the outdated PR was locked due to age label Jun 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
java Java use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants