Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hbase: require Java 8 exactly #28346

Closed
wants to merge 1 commit into from
Closed

hbase: require Java 8 exactly #28346

wants to merge 1 commit into from

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented May 27, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Addresses #19696 by requiring Java 8 exactly.

The install and test for hbase are not currently failing in the presence of Java 9, but when you actually use hbase on a machine with Java 9 installed, as is done in brew install -s opentsdb, then it throws Java 9 related errors.

@ilovezfs ilovezfs closed this in df05a7c May 28, 2018
@ilovezfs
Copy link
Contributor

Nice catch! Thanks @apjanke! It would be cool if the test block could catch that so someone doesn't accidentally put this back.

@apjanke apjanke deleted the hbase-jdk9-coexist branch May 28, 2018 07:22
@apjanke apjanke mentioned this pull request May 28, 2018
@lock lock bot added the outdated PR was locked due to age label Jun 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants