Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentsdb: require Java 8 specifically #28367

Closed
wants to merge 1 commit into from
Closed

opentsdb: require Java 8 specifically #28367

wants to merge 1 commit into from

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented May 28, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)? No, but it's not a regression.

Addresses #19696 by requiring Java 8 exactly.

The audit failure:

$ brew audit --strict opentsdb
opentsdb:
  * `Use :optional` or `:recommended` instead of `depends_on HbaseLZORequirement if build.with?("lzo")`
Error: 1 problem in 1 formula
[✘ ~]
$

This was present before this PR, so it's not a regression. Looks like an edge case for that cop; I don't see how to fix it with :optional or :recommended here. Could fix this by just removing the --without-lzo option from hbase so it's always present, and no need to define a special requirement.

@apjanke apjanke mentioned this pull request May 28, 2018
@ilovezfs
Copy link
Contributor

test block failed

@ilovezfs ilovezfs added the test failure CI fails while running the test-do block label May 28, 2018
@apjanke
Copy link
Contributor Author

apjanke commented May 28, 2018

I think I screwed up squashing commits when I pushed this initially.

Amended. Works locally for me.

@ilovezfs ilovezfs removed the test failure CI fails while running the test-do block label May 28, 2018
@ilovezfs
Copy link
Contributor

Thanks again @apjanke! 🏆

@ilovezfs ilovezfs closed this in 80b9ea9 May 28, 2018
@lock lock bot added the outdated PR was locked due to age label Jun 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants