Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javarepl: deprecate as unmaintained #96530

Closed
wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 8, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This deprecates javarepl based on upstream status.

There is also a Linux issue seen in #95575. It is possible to partially fix by adding java to PATH, but there is some behavior issue when shutting down (albertlatacz/java-repl#117) and test will need to be rewritten.

If someone wants to fix, they can, but for now just adding to deprecate --> disable --> remove workflow

@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Mar 8, 2022
@BrewTestBot BrewTestBot added formula deprecated Formula deprecated java Java use is a significant feature of the PR or issue labels Mar 8, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m mentioned this pull request Mar 9, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
@cho-m cho-m deleted the deprecate-javarepl branch June 2, 2022 04:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated java Java use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants