Remove mimetype #295
Open
Remove mimetype #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zachkrall
reviewed
Jan 8, 2025
| @@ -137,7 +137,7 @@ export const useSoundPlayer = (props: { | |||
| } | |||
|
|
|||
| try { | |||
| const blob = convertBase64ToBlob(message.data, 'audio/mp3'); | |||
| const blob = convertBase64ToBlob(message.data); | |||
There was a problem hiding this comment.
This triggers an error in the PR Check workflow.
packages/react postinstall: src/lib/useSoundPlayer.ts(145,22): error TS2554: Expected 2 arguments, but got 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labeling the audio that comes back from EVI with
audio/mp3is a lie. It's always WAV. We should just avoid labelling it, as putting a label on is unnecessary (the audio file has a header).Merging it now will cause a Typescript error, need
HumeAI/hume-typescript-sdk#251
to be merged/released (and then will need to update this PR to reference the new version).