fix typo in Job condition check

Signed-off-by: Zac Pitones <[email protected]>
IBM · May 24, 2024 · 5d226f4 · 5d226f4
1 parent d651383
commit 5d226f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/oper8/verify_resources.py b/oper8/verify_resources.py
@@ -144,7 +144,7 @@ def verify_pod(object_state: dict) -> bool:
 def verify_job(object_state: dict) -> bool:
     """Verify that a job has completed successfully"""
     # https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#JobStatus
-    return _verify_condition(object_state, "Completed", True)
+    return _verify_condition(object_state, "Complete", True)
 
 
 def verify_deployment(object_state: dict) -> bool:

diff --git a/tests/test_verify_resources.py b/tests/test_verify_resources.py
@@ -182,7 +182,7 @@ def test_verify_pod_custom_verification():
 
 def test_verify_job_completed():
     """Make sure a completed job verifies cleanly"""
-    assert run_test_verify(kind="Job", conditions=[make_condition("Completed", True)])
+    assert run_test_verify(kind="Job", conditions=[make_condition("Complete", True)])
 
 
 def test_verify_job_failed():
@@ -216,7 +216,7 @@ def test_verify_job_separate_namespace():
     """Make sure a completed job from a different namespace verifies cleanly"""
     assert run_test_verify(
         kind="Job",
-        conditions=[make_condition("Completed", True)],
+        conditions=[make_condition("Complete", True)],
         obj_namespace="adifferent",
         search_namespace="adifferent",
     )
@@ -226,7 +226,7 @@ def test_verify_job_null_namespace():
     """Make sure a completed job in the same namespace verifies cleanly"""
     assert run_test_verify(
         kind="Job",
-        conditions=[make_condition("Completed", True)],
+        conditions=[make_condition("Complete", True)],
         obj_namespace=TEST_NAMESPACE,
         search_namespace=_SESSION_NAMESPACE,
     )