Automatically mark unreviewed items as reviewed

Fixes doorstop-dev#184

This makes an item’s review status behave like
doorstop-dev#177.

.pydevproject

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" standalone="no"?>
 <?eclipse-pydev version="1.0"?><pydev_project>
-<pydev_property name="org.python.pydev.PYTHON_PROJECT_VERSION">python 2.7</pydev_property>
+<pydev_property name="org.python.pydev.PYTHON_PROJECT_VERSION">python 3.0</pydev_property>
 <pydev_property name="org.python.pydev.PYTHON_PROJECT_INTERPRETER">Doorstop</pydev_property>
 <pydev_pathproperty name="org.python.pydev.PROJECT_SOURCE_PATH">
 <path>/${PROJECT_DIR_NAME}</path>

doorstop/core/item.py

@@ -553,7 +553,10 @@ def get_issues(self, **kwargs):
         if not self.reviewed:
             if settings.CHECK_REVIEW_STATUS:
                 if not self._data['reviewed']:
-                    yield DoorstopInfo("needs initial review")
+                    if settings.REVIEW_NEW_ITEMS:
+                        self.review()
+                    else:
+                        yield DoorstopInfo("needs initial review")
                 else:
                     yield DoorstopWarning("unreviewed changes")
 

doorstop/core/test/test_all.py

@@ -110,11 +110,13 @@ def test_new(self):
         self.assertEqual(0, len(document.items))
 
     @patch('doorstop.settings.REORDER', False)
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_validate(self):
         """Verify a document can be validated."""
         self.assertTrue(self.document.validate())
 
     @patch('doorstop.settings.REORDER', False)
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_issues_count(self):
         """Verify a number of issues are found in a document."""
         issues = self.document.issues
@@ -123,6 +125,7 @@ def test_issues_count(self):
         self.assertEqual(12, len(issues))
 
     @patch('doorstop.settings.REORDER', False)
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_issues_duplicate_level(self):
         """Verify duplicate item levels are detected."""
         expect = DoorstopWarning("duplicate level: 2.1 (REQ002, REQ2-001)")
@@ -134,6 +137,7 @@ def test_issues_duplicate_level(self):
             self.fail("issue not found: {}".format(expect))
 
     @patch('doorstop.settings.REORDER', False)
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_issues_skipped_level(self):
         """Verify skipped item levels are detected."""
         expect = DoorstopInfo("skipped level: 1.4 (REQ003), 1.6 (REQ004)")
@@ -215,6 +219,7 @@ def test_reorder_with_start(self):
         self.assertListEqual(expected, actual)
 
     @patch('doorstop.settings.REORDER', True)
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_validate_with_reordering(self):
         """Verify a document's order is corrected during validation."""
         document = core.Document.new(None,
@@ -248,6 +253,7 @@ def tearDown(self):
 
     @patch('doorstop.settings.REORDER', False)
     @patch('doorstop.settings.STAMP_NEW_LINKS', False)
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     @patch('doorstop.core.document.Document', DocumentNoSkip)
     def test_validate_invalid_link(self):
         """Verify a tree is invalid with a bad link."""
@@ -257,6 +263,7 @@ def test_validate_invalid_link(self):
         self.assertFalse(tree.validate())
 
     @patch('doorstop.settings.REORDER', False)
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_validate_long(self):
         """Verify trees can be checked."""
         logging.info("tree: {}".format(self.tree))
@@ -476,6 +483,7 @@ def test_export_csv(self):
             self.assertEqual(expected, actual)
         move_file(temp, path)
 
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_export_tsv(self):
         """Verify a document can be exported as a TSV file."""
         path = os.path.join(FILES, 'exported.tsv')
@@ -490,7 +498,6 @@ def test_export_tsv(self):
             self.assertEqual(expected, actual)
         move_file(temp, path)
 
-    @unittest.skipUnless(os.getenv(ENV) or not CHECK_EXPORTED_CONTENT, REASON)
     def test_export_xlsx(self):
         """Verify a document can be exported as an XLSX file."""
         path = os.path.join(FILES, 'exported.xlsx')

doorstop/core/test/test_item.py

@@ -601,6 +601,7 @@ def test_validate_reviewed(self):
         stamp = 'c6a87755b8756b61731c704c6a7be4a2'
         self.assertEqual(stamp, self.item._data['reviewed'])
 
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_validate_reviewed_first(self):
         """Verify that a missing initial review leaves the stamp empty."""
         self.item._data['reviewed'] = Stamp(None)
@@ -723,6 +724,7 @@ def test_validate_tree_error(self):
         self.item.tree = mock_tree
         self.assertFalse(self.item.validate())
 
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_validate_both(self):
         """Verify an item can be checked against both."""
 
@@ -751,6 +753,7 @@ def _iter(self):  # pylint: disable=W0613
         self.assertTrue(self.item.validate())
 
     @patch('doorstop.settings.STAMP_NEW_LINKS', False)
+    @patch('doorstop.settings.REVIEW_NEW_ITEMS', False)
     def test_validate_both_no_reverse_links(self):
         """Verify an item can be checked against both (no reverse links)."""
 

doorstop/settings.py

@@ -34,6 +34,9 @@
 WARN_ALL = False  # display info-level issues as warnings
 ERROR_ALL = False  # display warning-level issues as errors
 
+# Review settings
+REVIEW_NEW_ITEMS = True  # automatically review new items during validation
+
 # Stamping settings
 STAMP_NEW_LINKS = True  # automatically stamp links upon creation