Always update pixels #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we didn't update unless we found METADATA.ome.xml
|
Tested at IDR/idr-metadata#650 (comment) |
This was referenced Aug 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7.
NB: this branch is on top of #6.
As discussed on that issue, we need to always update the
pixelstable withpath/nameto a file in the new Fileset. It doesn't seem to matter too much which file is picked.We pick the first
.zattrsfile we find (most top-level inwalk) but if we find aMETADATA.ome.xmlthen that is chosen in preference.This logic is now in the main
def sql()and outputs an extraupdateto the generated sql instead of being part of themkngff_fileset()function insetup.sql.