-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript Parser Implementation #54
Conversation
…method to parse objects. Use raw strings for tests
…amespace to GenericOptions
new-parser
Branch into main
for .NET 8 Features and TypeScript Parser Implementation
Hi @Denny09310 - since this is such a large change and based on a branch I already had let's target a PR to that branch, so that I can pull it down and test it out too. |
Yes, sorry I haven't noticed that I was targeting the branch 'main'. I've noticed some errors in the "SpeechSyntesis" package (I don't know if they were already present) that I should address asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! That was a lot to review!! I really appreciate this. Before it goes to main
, we'll need to rebase with main
first - and there will be merge conflicts.
This PR aims to merge the
new-parser
branch with themain
branch to leverage the new features provided by .NET 8. Additionally, we have replaced the old regex-based parser with a new TypeScript parser, ensuring enhanced performance and maintainability.Changes Made:
Merged
new-parser
Branch withmain
:main
branch.Replaced Old Regex Parser with New TypeScript Parser:
Testing and Verification:
Benefits:
Testing:
How to Review:
Code Changes:
Testing:
Documentation:
Checklist:
new-parser
branch withmain
.