Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Remove SpatialObjectProperty's writable string methods from SWIG #4843

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
BUG: Remove SpatialObjectProperty's writable string methods from SWIG
SWIG's binding for writable std::string objects is a "std::string *"
which is not implemented.
blowekamp committed Sep 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 80be78b343dce3a0b01e9bcaf48fbca3b53a9b29
12 changes: 6 additions & 6 deletions Modules/Core/SpatialObjects/include/itkSpatialObjectProperty.h
Original file line number Diff line number Diff line change
@@ -96,11 +96,13 @@ class ITKSpatialObjects_EXPORT SpatialObjectProperty
m_Name = name;
}

#if !defined(ITK_WRAPPING_PARSER)
std::string &
GetName()
{
return m_Name;
}
#endif

const std::string &
GetName() const
@@ -123,15 +125,13 @@ class ITKSpatialObjects_EXPORT SpatialObjectProperty
return value;
}


#if !defined(ITK_WRAPPING_PARSER)
bool
GetTagStringValue(const std::string & tag, std::string & value) const;
#endif
std::string
GetTagStringValue(const std::string & tag) const
{
std::string value = "";
this->GetTagStringValue(tag, value);
return value;
}
GetTagStringValue(const std::string & tag) const;


std::map<std::string, double> &
9 changes: 9 additions & 0 deletions Modules/Core/SpatialObjects/src/itkSpatialObjectProperty.cxx
Original file line number Diff line number Diff line change
@@ -137,6 +137,15 @@ SpatialObjectProperty::GetTagStringValue(const std::string & tag, std::string &
}
}


std::string
SpatialObjectProperty::GetTagStringValue(const std::string & tag) const
{
std::string value = "";
this->GetTagStringValue(tag, value);
return value;
}

std::map<std::string, double> &
SpatialObjectProperty::GetTagScalarDictionary()
{