Skip to content

Commit

Permalink
Update ScottPlot.csproj
Browse files Browse the repository at this point in the history
  • Loading branch information
swharden committed Apr 13, 2024
1 parent a697bef commit 52f9475
Showing 1 changed file with 22 additions and 5 deletions.
27 changes: 22 additions & 5 deletions src/ScottPlot4/ScottPlot/ScottPlot.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,28 @@
<ItemGroup>

<!--
Keep System.Drawing.Common version at 4.6.1 and users can upgrade it if they wish.
Upgrading may improve font rendering on Linux and MacOS, but upgrading then downgrading
is associated with assembly issues that break .NET Framework projects on Windows.
https://github.com/ScottPlot/ScottPlot/issues/1004
-->
The PublicApiAnalyzers throws tons of warnings if a change was made to the public API.
In theory this makes it easy to ensure code modifications don't break existing code.
In practice, this makes it frustrating and difficult for contributors to intentionally
add or modify the public API. It turned-out to be more trouble than it was worth, so
I'm disabling it.
-->
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.3" Condition="false">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>

<!-- Code analysis -->
<PackageReference Include="Microsoft.CodeAnalysis.Metrics" Version="*">
<PrivateAssets>all</PrivateAssets>
</PackageReference>

<!--
Keep System.Drawing.Common version at 4.6.1 and users can upgrade it if they wish.
Upgrading may improve font rendering on Linux and MacOS, but upgrading then downgrading
is associated with assembly issues that break .NET Framework projects on Windows.
https://github.com/ScottPlot/ScottPlot/issues/1004
-->
<PackageReference Include="System.Drawing.Common" Version="5.0.3" />
<PackageReference Include="System.Numerics.Vectors" Version="4.5.0" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
Expand Down

0 comments on commit 52f9475

Please sign in to comment.