Feat: add fsharp support #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nsidorenco
commented
Sep 26, 2024
| for _, captures in parsed_query:iter_matches(root, source) do | ||
| and vim.treesitter.query.parse(lang, framework_query) | ||
| or vim.treesitter.parse_query(lang, framework_query) | ||
| for _, node, _, _ in parsed_query:iter_captures(root, source) do |
There was a problem hiding this comment.
Not sure if this changes the behavior or not, but on nightly iter_matches have been changed/fixed to return all matches instead of only the last one.
Nsidorenco
commented
Sep 26, 2024
Comment on lines
+12
to
+19
| require("plenary.filetype").add_table({ | ||
| extension = { | ||
| ["fs"] = [[fsharp]], | ||
| ["fsx"] = [[fsharp]], | ||
| ["fsi"] = [[fsharp]], | ||
| }, | ||
| }) | ||
|
|
There was a problem hiding this comment.
Needed since plenary does not know about fsharp and neotest uses plenary's file detection
Nsidorenco
force-pushed
the
feat/fsharp
branch
from
57f3ffa to
c55d700
Compare
Nsidorenco
force-pushed
the
feat/fsharp
branch
from
c55d700 to
33dc436
Compare
Nsidorenco
force-pushed
the
feat/fsharp
branch
from
860b224 to
4538c8e
Compare
|
Hi @Nsidorenco . Thank you for this work! It looks good! I have a few other things on my plate at the moment, but I'll come back to this ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for FSharp files using the fsharp tree sitter grammar.
Will eventually close #82